Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest) : Add licenseInfoHeaderText in summaryAdministration api response #2881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rest) : Add licenseInfoHeaderText in summaryAdministration api response #2881

wants to merge 1 commit into from
+1 −1

Conversation

keerthi-bl
Copy link
Contributor

@keerthi-bl keerthi-bl commented Jan 22, 2025 •
edited
Loading

Please provide a summary of your changes here.

Adding licenseInfoHeaderText parameter in summaryAdministration api response.

How To Test?

API end point : projects/{projectId}/summaryAdministration .

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@keerthi-bl keerthi-bl force-pushed the fix/addLicInfHdTxtParamToSumAdmnPage branch from 213b54e to f5f875d Compare January 22, 2025 06:41
@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jan 23, 2025
GMishx
GMishx approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx
Copy link
Member

GMishx commented Jan 27, 2025

For the issue #2867 to be marked as solved, the request should respond with default licenseInfoHeaderText in case the project does not have one (the text from GET /projects/licenseInfoHeader).

@GMishx
Copy link
Member

GMishx commented Jan 31, 2025

Any updates @keerthi-bl ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees
No one assigned
Labels
needs general test This is general testing, meaning that there is no org specific issue to check for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add licenseInfoHeaderText in summaryAdministration api response
2 participants
@keerthi-bl @GMishx